Types for version getter #1982
Merged
Types for version getter #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abetomo
reviewed
Aug 26, 2023
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This was referenced Jun 19, 2024
This was referenced Jul 16, 2024
This was referenced Sep 11, 2024
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The implementation for
.version()has always supported returning the (previously defined) version string, but thetypes have never included this. I did briefly consider deprecating the whole thing (#1954), but it is being used in the wild
and not hard to support!
Solution
Small change to types and JSDoc and TSDoc to include the getter behaviour.